test: eliminate remaining stale gittensory references from test fixtures#6906
Conversation
Sweeps the rest of test/ for lingering pre-rename "gittensory" text that PR #6900 didn't already cover -- arbitrary example values, prose comments, and non-functional identifiers with no behavioral dependency on the real GITHUB_APP_SLUG or LOOPOVER_REVIEW_REPOS defaults. Purely 1:1 string swaps, no logic changes. Verified via three full unsharded npm run test:coverage passes. The first (before rebasing onto #6900/#6902) was green on a stale base. After reconciling onto the new origin/main, the second surfaced 3 files (rag-index.test.ts, reputation-wiring.test.ts, ci-completion-fork-resume.test.ts) where the renamed repo identity happened to be the SAME value load-bearing against LOOPOVER_REVIEW_REPOS's still-current "JSONbored/gittensory,acme/widgets" allowlist default -- reverted those three back to "gittensory" to keep the allowlist match, matching the same reasoning #6900 already applied to GITHUB_APP_SLUG-dependent fixtures. The third run confirmed clean: 949 files, 18084 tests, 0 failures.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6906 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 685 685
Lines 68292 68292
Branches 18718 18718
=======================================
Hits 63993 63993
Misses 3302 3302
Partials 997 997
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-17 17:10:15 UTC
Review summary Nits — 4 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
GITHUB_APP_SLUGorLOOPOVER_REVIEW_REPOSdefaults.GITHUB_APP_SLUGdefault + its real dependents, and cleaned up the orphaned terraform test / sentry-release assertion) — this PR only touches the files those didn't.Notes
gittensory-nativeDB-source literal, Sentry ticket IDs,GITTENSORY_LEGACY_*_CHECK_NAMEupgrade-compat constants, and the genericJSONbored/gittensoryplaceholder-repo pattern used elsewhere as a stand-in value.rag-index.test.ts,reputation-wiring.test.ts,ci-completion-fork-resume.test.ts) were caught and reverted back to"gittensory"during verification, because their renamed repo identity was actually the value matched againstLOOPOVER_REVIEW_REPOS's still-current"JSONbored/gittensory,acme/widgets"allowlist default — same category of dependency fix(test): rename the stale gittensory GITHUB_APP_SLUG default to loopover-orb #6900 already handled forGITHUB_APP_SLUG.Test plan
npm run test:coverage(full, unsharded) — 949 files / 18084 tests passed, 0 failures, run against this exact diff post-rebase.