Repository navigation
update clist for ros2 - #24
Closed
emackinnon1 wants to merge 1 commit into
Closed
emackinnon1 wants to merge 1 commit into
emackinnon1 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The pinned Dynamixel dependency does not provide the newly referenced namespaced CMake target.
1 open finding
What changed in this PR
Updates ROS 2 CMake integration for newer distributions.
Changes:
- Raises the minimum CMake version.
- Modernizes dependency linking and exported targets.
- Exposes generated headers through the build interface.
| File | Description |
|---|---|
CMakeLists.txt |
Updates dependency, linking, and export configuration. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+31
to
+34
| target_link_libraries(${PROJECT_NAME} PUBLIC | ||
| dynamixel_workbench_toolbox::dynamixel_workbench_toolbox | ||
| yaml-cpp | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates for newer ros2 distros