test(cadence): fixture and regression test for a populated top-level property bag - #232
Merged
Merged
Conversation
…ed property bag The OpenCellular SDR fixture sets per-page reference ranges and was re-annotated afterwards, so its Hierarchy stream carries trailing preamble data before the occurrence count and occurrence designators that differ from the inline page copies. The test pins that the stream parses and that every reference on the board's assembly BOM is reported under its annotated name; both assertions fail on the parser that skips a fixed 8 bytes there.
valentinozegna
force-pushed
the
test/opencellular-sdr-fixture
branch
from
September 22, 2026 18:20
f0f0964 to
c9be3d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #231; refs #230. Merge after #231, then this PR reduces to the test, the golden file and the submodule bump.
Summary
opencellular-sdrfixture (Add a Cadence fixture with per-page reference ranges (OpenCellular SDR) test-fixtures#12): a 34-page OrCAD design that sets per-page reference ranges and was re-annotated, so itsHierarchystream carries a populated top-level property bag. None of the existing 15 Cadence fixtures does.main's parser both assertions fail: the stream throws, the parser falls back to inline references, 242 BOM references go missing and 323 stale designators appear.Test plan
npm test: 1,374 passed on this branchmain'shierarchy-parser.tsswapped in (Expected occurrence (type 66), got 5; 1,214 components instead of 1,210)npm run type-checkandnpm run lintclean🤖 Generated with Claude Code
https://claude.ai/code/session_016wBHd6ZnfPGgAY5sdv9wD6