Fix CommandFailed not emitted when project/document validation fails - #437
Merged
BenjaminMichaelis merged 2 commits intoAug 15, 2026
Conversation
The @microsoft/polyglot-notebooks library changed behavior so that errors thrown inside command handlers are now swallowed via .catch() instead of being passed to context.fail(). This caused the 'cannot open document if there is no open project' test to fail because no CommandFailed event was emitted. Fix by replacing throw calls with explicit context.fail() calls in all command handlers in projectKernel.ts. Co-authored-by: BenjaminMichaelis <[email protected]>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job by identifying root cause
Fix CommandFailed not emitted when project/document validation fails
Aug 15, 2026
BenjaminMichaelis
marked this pull request as ready for review
August 15, 2026 13:40
BenjaminMichaelis
merged commit Aug 15, 2026
0dff50f
into
dependabot/npm_and_yarn/src/microsoft-trydotnet-editor/microsoft/polyglot-notebooks-1.0.740304
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@microsoft/polyglot-notebookschanged its command dispatch so errors thrown inside handlers are now swallowed via.catch()rather than propagated tocontext.fail(). This broke all guard checks inProjectKernel— e.g. sendingOpenDocumentwithout an open project silently succeeded instead of emitting aCommandFailedevent.Changes
src/projectKernel.ts— Replace allthrow new Error(...)guard patterns with explicitcommandInvocation.context.fail(message); return;in every command handler (SubmitCode,OpenDocument,RequestDiagnostics,RequestCompletions,RequestHoverText,RequestSignatureHelp)throwIfProjectIsNotOpened()andthrowIffDocumentIsNotOpened()methodsBefore:
After: