chore: remove Microsoft.DotNet.Arcade.Sdk - #410
Merged
Conversation
Co-authored-by: BenjaminMichaelis <[email protected]>
Copilot created this pull request from a session on behalf of
BenjaminMichaelis
August 12, 2026 16:24
View session
…ly race Co-authored-by: BenjaminMichaelis <[email protected]>
BenjaminMichaelis
temporarily deployed
to
BuildAndUploadImage
August 12, 2026 17:16 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR removes the Microsoft.DotNet.Arcade.Sdk MSBuild SDK and associated Arcade infrastructure, simplifying the repo to build/test with plain dotnet tooling and reducing maintenance overhead.
Changes:
- Removed Arcade SDK wiring (global.json MSBuild SDKs, Directory.Build imports/properties, Arcade-specific eng files).
- Simplified NuGet restore configuration and central package management so test SDK dependencies are explicit.
- Adjusted CI to constrain integration test parallelism.
Reviewed changes
Copilot reviewed 167 out of 167 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/Build-Test-And-Deploy.yaml | Updates integration test invocation to limit parallel test assemblies. |
| Directory.Build.props | Removes Arcade SDK import and Arcade-only properties. |
| Directory.Build.targets | Removes Arcade SDK targets import. |
| Directory.Packages.props | Makes Microsoft.NET.Test.Sdk centrally versioned unconditionally (not Arcade-gated). |
| NuGet.config | Removes Arcade-style feed setup; keeps only required sources. |
| eng/AfterSolutionBuild.targets (deleted) | Removes Arcade hook into PackageReleasePackages. |
| eng/CIBuild.cmd (deleted) | Removes Arcade wrapper build entrypoint. |
| eng/cibuild.sh (deleted) | Removes Arcade wrapper build entrypoint. |
| eng/Publishing.props (deleted) | Removes Arcade publishing infrastructure. |
| eng/SignCheckExclusionsFile.txt (deleted) | Removes Arcade sign-check exclusions. |
| eng/Signing.props (deleted) | Removes Arcade signing infrastructure. |
| eng/Version.Details.xml (deleted) | Removes Maestro/Darc dependency-flow manifest. |
| eng/Versions.props | Removes Arcade tool flags and Arcade-referencing version-calculation comment. |
| eng/common/** (deleted) | Deletes shared Arcade scripts/templates/SDL/source-build helpers. |
| eng/templates/** (deleted) | Deletes Azure DevOps pipeline templates. |
| eng/targets/Settings.props | Replaces Arcade-defined properties with a literal and removes Arcade-only properties. |
| eng/targets/Versions.targets | Removes Arcade-specific _InitializeAssemblyVersion override target. |
| global.json | Removes msbuild-sdks entry for Microsoft.DotNet.Arcade.Sdk. |
| src/Microsoft.TryDotNet.IntegrationTests/Microsoft.TryDotNet.IntegrationTests.csproj | Makes Microsoft.NET.Test.Sdk explicit and removes Arcade-gating of the publish helper target. |
| src/Microsoft.TryDotNet.Tests/Microsoft.TryDotNet.Tests.csproj | Makes Microsoft.NET.Test.Sdk explicit (not Arcade-gated). |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
71
to
73
| <Target Name="PublishTool" BeforeTargets="CoreCompile"> | ||
| <Exec Command="dotnet publish -o $(PublishLocation)" WorkingDirectory="$(MSBuildThisFileDirectory)..\Microsoft.TryDotNet" /> | ||
| </Target> |
Comment on lines
8
to
10
| <!-- Microsoft.DotNet.Interactive.CSharpProject is not published to nuget.org --> | ||
| <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" /> | ||
| <add key="dotnet-libraries" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json" /> | ||
| <add key="dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" /> | ||
| <add key="MachineLearning" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/MachineLearning/nuget/v3/index.json" /> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> |
Author
There was a problem hiding this comment.
Moved nuget.org before dotnet-tools in NuGet.config so restores prefer nuget.org for packages available on both sources.
…st command Co-authored-by: BenjaminMichaelis <[email protected]>
Co-authored-by: BenjaminMichaelis <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Microsoft.DotNet.Arcade.SdkMSBuild SDK and all associated Arcade infrastructure. The CI pipeline already uses plaindotnetcommands; Arcade was carrying dead weight.Deleted
eng/common/— shared Arcade scripts, Azure DevOps templates, source-build helperseng/templates/— Azure DevOps pipeline templateseng/Version.Details.xml— Darc/Maestro dependency-flow manifesteng/Signing.props,eng/Publishing.props,eng/SignCheckExclusionsFile.txt— Arcade signing/publishing pipelineeng/AfterSolutionBuild.targets— hook into Arcade'sPackageReleasePackagestargeteng/CIBuild.cmd,eng/cibuild.sh— wrappers around Arcade'sbuild.cmdModified
global.json— removedmsbuild-sdksentryDirectory.Build.props/targets— removedSdk.props/Sdk.targetsimports and Arcade-only properties (DotNetUseShippingVersions)eng/Versions.props— removed Arcade tool flags (UsingToolNuGetRepack,UsingToolSymbolUploader, etc.) and Arcade-referencing comment in version calculationeng/targets/Settings.props— replaced$(CopyrightMicrosoft)(Arcade-defined) with a literal; removed$(ArtifactsBinDir)/NuspecBasePathNuGet.config— replaced five Azure DevOps package feeds (Arcade convention for .NET Foundation repos) with justnuget.orgDirectory.Packages.props+ test.csprojfiles — droppedDisableArcadeconditions;Microsoft.NET.Test.Sdkis now unconditionally referenced (Arcade previously injected it automatically)