feat(demo): switch from Expo Go to a local development build - #1338
Conversation
| name: 'demo', | ||
| newArchEnabled: true, | ||
| name: 'Hyperview Demo', | ||
| newArchEnabled: false, |
There was a problem hiding this comment.
we probably don't want to switch that off?
There was a problem hiding this comment.
See the bullet above in the description. There's a known bug with our current combination of packages.
There was a problem hiding this comment.
I see, are you re-enabling it in your upcoming PR that uses native stack?
There was a problem hiding this comment.
native-stack won't fix it. The issue is with react-native-screens. We can't re-enable the flag until we test with a newer version (>= 4.18.0).
There was a problem hiding this comment.
Removed as part of upgrade to Expo 57
flochtililoch
left a comment
flochtililoch
left a comment
There was a problem hiding this comment.
Do we also need to update scripts/update-demo.sh? Will you take care of updating to the latest Expo in a follow up PR?
| }, | ||
| name: 'demo', | ||
| newArchEnabled: true, | ||
| name: 'Hyperview Demo', |
There was a problem hiding this comment.
Minor nit: since the name is truncated on Android, might be best renaming to "Hyperview" or "HV Demo"
There was a problem hiding this comment.
Updated to "Hyperview" to fit better
944591a to
f6a97f7
Compare
f6a97f7 to
fc4412c
Compare
fc4412c to
3d31089
Compare
3d31089 to
c263ef2
Compare
c263ef2 to
00e0391
Compare
Android truncates "Hyperview Demo" on the home screen.
RN 0.86.3 already ships fmt 12.1, so the Podfile header patch is unused. Align the install docs with the Hyperview display name.
The development build already uses icon.png as the Android adaptive foreground, and the two files were identical.
67b636c to
79baf8b
Compare
009f7f5
into
hardin/demo-expo-integration
2 participants
Summary
expo-dev-client+expo run:ios/expo run:android).http://127.0.0.1:8085.0.0.0.0is a listen address; iOS will not load it. Physical devices still passBASE_URLwith the machine’s LAN IP.org.hyperview.demo.color="black"on shared text styles. Expo Go’s Android theme defaults unstyled text to black; a development build uses DayNighttextColorPrimary(faded).update-demo.shinstallsexpo-dev-clientandreact-native-worklets.Asana