refactor(e2e/android): [BREAKING] remove createTestProps - #1312
Draft
flochtililoch wants to merge 1 commit into
Draft
refactor(e2e/android): [BREAKING] remove createTestProps#1312flochtililoch wants to merge 1 commit into
createTestProps#1312flochtililoch wants to merge 1 commit into
Conversation
flochtililoch
force-pushed
the
florent/test-id-fixes
branch
from
July 17, 2026 20:24
8815b53 to
af6759c
Compare
hgray-instawork
approved these changes
Jul 20, 2026
flochtililoch
marked this pull request as draft
August 18, 2026 17:16
flochtililoch
force-pushed
the
florent/test-id-fixes
branch
from
August 19, 2026 19:17
af6759c to
0a2d7ed
Compare
BREAKING CHANGE: stop using `accessibilityLabel` on Android as a test ID. The origin of this hack was to work around our test automation framework, which is being fixed: both Android and iOS can use the `testID` prop consistently. This improves accessibility of apps built with Hyperview, since the accessibility label is not longer overriden by a label readable by machines only. We will revisit in a future PR the ability to set the `accessibilityLabel` via a new attribute. Simplifies test ID assignment across elements by dropping createTestProps in favor of setting testID from the id attribute on all platforms.
flochtililoch
force-pushed
the
florent/test-id-fixes
branch
from
August 19, 2026 20:55
0a2d7ed to
4f02225
Compare
flochtililoch
changed the title
createTestPropscreateTestProps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
BREAKING CHANGE
This change removes the
createTestPropsmethod from the public API. If you're using it, update your code before updating Hyperview. You can now just settestIDprop directly.Stop using
accessibilityLabelon Android as a test ID. The origin of this hack was to work around our test automation framework, which is being fixed: both Android and iOS can use thetestIDprop consistently. This improves accessibility of apps built with Hyperview, since the accessibility label is not longer overriden by a label readable by machines only. We will revisit in a future PR the ability to set theaccessibilityLabelvia a new attribute.