Cache matcher fields - 6% improvement - #1470
Open
tpolasek wants to merge 1 commit into
Open
Conversation
Cache immutable dataclass field definitions by matcher type instead of resolving them for every recursive LibCST matcher comparison. Add coverage for cache reuse and matcher behavior.
meta-cla
Bot
added
the
CLA Signed
stroxler
requested changes
Aug 25, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
I think the change is good, but it looks like it needs some adjustments to pass the CI gate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache immutable dataclass field definitions by matcher type instead of resolving them for every recursive LibCST matcher comparison.
Test Plan
Add coverage for cache reuse and matcher behavior.