[ddecrulle]

Problem

Onyxia fills chart values from user input and installs the chart as cluster-admin. Values interpolated without quoting (or wrapped only in literal quotes) can break out of their YAML scalar: a value with newlines and --- injects arbitrary manifests (e.g. a ClusterRoleBinding to cluster-admin). Same class of bug as InseeFrLab/helm-charts-interactive-services#332.

An audit rendering every free-text schema field with such a payload found 39 injectable fields in this repo's own templates and 22 more through third-party subcharts (plus fields behind disabled feature flags, e.g. s3.*).

Fix

Where the value lands	Fix
YAML scalar in our templates	| quote, | int (ports, replicas, probes), printf … | quote when text surrounds the value (repo:tag, connection strings, test args)
JSON / Python string in our templates (cloudbeaver.conf, opensearch test)	| toJson
XML (hive-metastore, trino core-site), .properties (trino), shell (pgadmin), the S3 secret of the old library-chart (spark-history, spark-thrift-server), third-party subcharts (Bitnami postgresql, chromadb, dask, elasticsearch, milvus, qdrant)	single-line pattern (^[^\n\r]*$) in values.schema.json — quoting is impossible there, helm rejects the value before rendering

pattern is used rather than format: helm enforces pattern but does not assert format (an email/uri field accepts any string).

Also: postgresql-cnpg did not render with its own defaults (imageCatalog.major: 18 vs the schema's string); the default is now "18" and it renders with | int, as the CNPG Cluster CRD expects an integer.

Regression test

utils/test_yaml_injection.py + .github/workflows/yaml-injection-test.yaml (same script as helm-charts-interactive-services): tests the charts changed by a PR / push to main, all charts on workflow_dispatch. Feature flags of each field's parents are switched on so gated values are covered.

Verification

• Injection test: 22/22 charts safe; removing a single | quote is caught.
• Default renders compared object by object before/after: unchanged except randomly generated secrets/certificates (differ on every render) and the intended quoting in cloudbeaver.conf and the opensearch test script.
• helm lint passes on every chart; versions bumped.

Pre-existing bugs found (not fixed here)

• opensearch: enabling route.enabled breaks the chart (app.kubernetes.io/component: - label).
• opensearch: opensearch.StrongPassword uses the user's password as a printf format string, so a password containing % is altered.

Limits

• The pattern protection relies on helm's schema validation at install time (i.e. Onyxia not passing --skip-schema-validation).
• It covers the fields exposed in the schema. Keys passed beyond the form (e.g. Bitnami extraDeploy) are not covered by any chart-level fix; least privilege for the installing identity is the real boundary there.

🤖 Generated with Claude Code