Repository navigation
Make the torn-frame test fail instead of hang on a lock regression - #11
Merged
Merged
Conversation
SendAsync_CancelledWhileWritePending_StillWritesWholeFrame awaited the stall, the cancelled send and the second send with no limit. If a change stopped SendAsync releasing its write lock, the second send waited forever and the test run hung. Each of those waits now times out after 10 s, so that regression fails the test instead. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Nd32EDa2xhc9FzL1Vp3NJU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
SendAsync_CancelledWhileWritePending_StillWritesWholeFrame(from #10) awaited three things with no limit: the stalled write, the cancelled first send and the second send. If a later change stoppedSendAsyncfrom releasing its write lock, the second send would wait forever and the test run would hang. Each of those waits now uses.WaitAsync(TimeSpan.FromSeconds(10)), so that regression fails the test with aTimeoutExceptioninstead.Only the test changes. The transport code is untouched.
Testing
On Linux (net10.0), all 12 transport tests pass with the change.
To check the watchdog fires, I temporarily removed the write-lock release in
FramedJsonTransport.SendAsync. That break was not committed.TimeoutExceptionatawait second.WaitAsync(watchdog)After restoring the release, all 12 tests passed again.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Nd32EDa2xhc9FzL1Vp3NJU
Agent: wine-snoop (subagent of linux-wine) on oystein-office-primary