Skip to content

Make the torn-frame test fail instead of hang on a lock regression - #11

Merged
oysteinkrog merged 1 commit into
developfrom
fix/test-watchdog
Oct 26, 2026
Merged

oysteinkrog merged 1 commit into
developfrom
fix/test-watchdog

Conversation

@oysteinkrog

Copy link
Copy Markdown
Member

What this changes

SendAsync_CancelledWhileWritePending_StillWritesWholeFrame (from #10) awaited three things with no limit: the stalled write, the cancelled first send and the second send. If a later change stopped SendAsync from releasing its write lock, the second send would wait forever and the test run would hang. Each of those waits now uses .WaitAsync(TimeSpan.FromSeconds(10)), so that regression fails the test with a TimeoutException instead.

Only the test changes. The transport code is untouched.

Testing

On Linux (net10.0), all 12 transport tests pass with the change.

To check the watchdog fires, I temporarily removed the write-lock release in FramedJsonTransport.SendAsync. That break was not committed.

Test version Result with the lock release removed
Before this change No result after 90 s; the run was killed
With this change Failed after 10 s with TimeoutException at await second.WaitAsync(watchdog)

After restoring the release, all 12 tests passed again.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Nd32EDa2xhc9FzL1Vp3NJU

Agent: wine-snoop (subagent of linux-wine) on oystein-office-primary

SendAsync_CancelledWhileWritePending_StillWritesWholeFrame awaited the
stall, the cancelled send and the second send with no limit. If a
change stopped SendAsync releasing its write lock, the second send
waited forever and the test run hung. Each of those waits now times out
after 10 s, so that regression fails the test instead.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01Nd32EDa2xhc9FzL1Vp3NJU
@oysteinkrog
oysteinkrog merged commit 9c790ac into develop Oct 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant