Add option to filter livestreams from the feed#80
Open
murosorg wants to merge 1 commit into
Open
Conversation
Adds a "Filter livestreams" switch in the content filter settings that removes livestreams (LIVE_STREAM and AUDIO_LIVE_STREAM) from the subscriptions feed, following the same pattern as the existing "Filter future items" option. Signed-off-by: murosorg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add an option to hide livestreams from the subscriptions feed, alongside the other content filters.
Behavior
A new "Filter livestreams" switch is added to the content filter settings (next to "Filter future items"). When enabled, livestreams (
LIVE_STREAMandAUDIO_LIVE_STREAM) are removed from the feed. Disabled by default, so existing behavior is unchanged.Changes
filter_settings.xml: newSwitchPreferenceforfilter_livestreams_key.settings_keys.xml/strings.xml: new preference key, title and summary.FilterSettingsFragment.java: wire the new preference (same pattern as the other filters).FeedLoadManager.kt: read the preference and, when enabled, filter out livestreams during feed load, using the existingStreamTypeUtil.isLiveStream(...)helper and the samefilterNotpipeline as the future-items filter.Notes
Applied at feed load time, consistent with the existing "Filter future items" filter.