Skip to content

Fix jagged test oracles - #202

Open
voltjia wants to merge 2 commits into
gate-materialization-testsfrom
fix-jagged-test-oracles
Open

Fix jagged test oracles#202
voltjia wants to merge 2 commits into
gate-materialization-testsfrom
fix-jagged-test-oracles

Conversation

@voltjia

@voltjia voltjia commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace jagged test expectations with explicit padded and values oracles
  • probe jagged_dim=1 and jagged_dim=2 independently before collecting GPU cases
  • skip only layouts the installed PyTorch runtime cannot construct

Functional implementation validation before restoring the original assertion API:

pytest output:

NVIDIA: 21 passed in 34.05s
Hygon: 21 passed in 64.76s
Iluvatar: 13 passed, 8 skipped in 12.74s

Latest head b6aced9a validation after restoring the two pre-existing torch.allclose assertions:

NVIDIA: 21 passed in 25.24s
Iluvatar: 13 passed, 8 skipped in 12.07s
Hygon: not rerun because the host was temporarily unreachable via SSH

The Iluvatar skips are limited to jagged_dim=2, which its PyTorch runtime reports cannot be represented with the jagged layout.

@voltjia
voltjia marked this pull request as ready for review July 22, 2026 09:08
@voltjia
voltjia force-pushed the gate-materialization-tests branch from 6773cfe to a10f62b Compare July 24, 2026 07:50
@voltjia
voltjia force-pushed the fix-jagged-test-oracles branch from 06a770a to 36f81b3 Compare July 24, 2026 07:50
@voltjia
voltjia requested a review from whjthu July 28, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant