Fix jagged test oracles - #202
Open
voltjia wants to merge 2 commits into
Open
Conversation
voltjia
marked this pull request as ready for review
July 22, 2026 09:08
voltjia
force-pushed
the
gate-materialization-tests
branch
from
July 24, 2026 07:50
6773cfe to
a10f62b
Compare
voltjia
force-pushed
the
fix-jagged-test-oracles
branch
from
July 24, 2026 07:50
06a770a to
36f81b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jagged_dim=1andjagged_dim=2independently before collecting GPU casesFunctional implementation validation before restoring the original assertion API:
pytestoutput:Latest head
b6aced9avalidation after restoring the two pre-existingtorch.allcloseassertions:The Iluvatar skips are limited to
jagged_dim=2, which its PyTorch runtime reports cannot be represented with the jagged layout.