refactor(ops): remove InfiniLM-suffixed InfiniOps calls - #1483
Open
voltjia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
KvCachingInfinilm,PagedAttentionPrefillInfinilm,RandomSampleInfinilm, andRotaryEmbeddingInfinilmAPIs.PagedAttentionInfinilmdecode fallback with the existing InfiniOP paged-attention provider while retaining canonicalFlashAttnWithKvcachedispatch for supported layouts.FlashAttnWithKvcacheandFlashAttnVarlenFuncAPIs.Migration
kv_cachingKvCachingInfinilmpaged_attention_prefillPagedAttentionPrefillInfinilmrandom_sampleRandomSampleInfinilmropeRotaryEmbeddingInfinilmpaged_attentiondecode layoutsPagedAttentionInfinilmpaged_attention_impl::infiniop::{plan, run, cleanup}pathpaged_attentiondecode layoutsFlashAttnWithKvcachepath retainedmha_varlenlayoutsFlashAttnVarlenFuncpath retainedScope
No public InfiniCore Python or C++ API changes are introduced, and the InfiniOps gitlink is unchanged. The existing InfiniOP implementations become the fallback providers; this PR does not add another operator implementation.
This PR is stacked on #1481 (
refactor/migrate-paged-attention-infiniops) so its diff contains only the suffix-removal work. It can be retargeted tomainafter #1481 merges.Screenshots: N/A (backend adapter migration only).
Validation
Run on
ssh nvidiainaccelerator-dev/nvidia:lateston NVIDIA A100 GPUs:git diff --checkpassed.FlashAttnWithKvcacheandFlashAttnVarlenFunc; full InfiniCore shared-library builds passed.libinfinicore_cpp_api.so,_infinicore, andlibinfiniops.sofound noInfinilmsymbols.src/infinicoreandxmake.luafound no InfiniLM-suffixed InfiniOps references.kv_caching36/36,random_sample32/32,rope162/162,paged_attention_prefill76/76, andpaged_attention22/22.