Skip to content

Handle linting better #48

Closed
Closed

Description

@thompsonmj

In #47, unpinned linting tied to CI passing caused issues as described here..

To address this, we should do the following:

  • Pin the Ruff version to 0.16 in the pyproject
  • Change the pre-commit hook to use repo: local and use uv run --extra ruff check --force-exclude. This uses the pyproject ruff version as a single source of truth, fixing the current mismatch between the hook and the pyproject. (Adding --force-exclude protects the hook from causing unexpected errors while not costing any additional complexity)
  • No update to Actions for this ... it will install ruff from the pyproject file still.

With this approach, a developer can do uv pip install -e .[dev] to do independent ruff check . commands, and this will be in sync with the pre-commit hook as well as the CI linter based on the single source of truth in the pyproject file.

Activity

  1. thompsonmj commented on Jul 29, 2026

    @thompsonmj
    CollaboratorAuthor

    Closed by #52, with additional related work planned in #49, #50, and #51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions