feat(settings): implement IDelegatedSettings for activity admin settings - #4
Open
printminion-co wants to merge 1 commit into
Open
feat(settings): implement IDelegatedSettings for activity admin settings#4printminion-co wants to merge 1 commit into
printminion-co wants to merge 1 commit into
Conversation
Signed-off-by: Kai Henseler <[email protected]>
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vanilla-clean extraction of the IONOS delegation patch carried in PR #2 (
IONOS(admin-settings): convert to delegated setting, cherry-picked from ca3cd2e), prepared per upstream-to-vanilla-app.md for contribution tonextcloud/activity.OCA\Activity\Settings\Adminchanges fromimplements ISettingstoimplements IDelegatedSettings, addinggetName()andgetAuthorizedAppConfig(). This is app-side only — no ncw-configADMIN_DELEGATION_MAPregistration is included, so it stands on its own upstream.Why
Every NC major re-applies this same one-file patch onto the fork (v31, now v32 in PR #2, v33 next). Upstreaming it retires that delta permanently. Sibling of the already-open nextcloud/bruteforcesettings#1246.
Preparation notes
nextcloud/activity:master; this fork'smastermirror is currently identical to it, so the diff is exactly the one commit.IONOS(...)prefix, no NSW/HDNEXT token, no fork-internal PR or SHA reference.Signed-off-by: Kai Henselerpreserved; no sign-off added.#[\Override]added to the two new methods — the v31-era source commit predates them, but upstream'sAdmin.phpmarks every other interface method with it, as does Create pr-feedback.yml nextcloud/activity#1246.Verification
Run in the shared dev container (
.dev/container/dev) from the ncw-server checkout:composer lint— cleancomposer cs:check— clean, 0 of 98 files need fixingcomposer psalm— could not run: the app pins Psalm 7.0.0-beta19, which requires PHP >= 8.3.16; the container has PHP 8.3.6. Pre-existing environment gap, identical fornc-password_policy, unrelated to this change.Related
nextcloud/activity:master