Repository navigation
Conversation
"modify rr NAME a IP" and "show rr NAME a IP" had no layer3domain argument and ignored NDCLI_LAYER3DOMAIN / layer3domain= in ~/.ndclirc. When IP exists in more than one layer3domain the server cannot pick one and answered "A layer3domain is needed" with no way for the user to supply it. They now take "layer3domain NAME" and the configured default, exactly like "create rr" and "delete rr". The server drops layer3domain after using it to resolve the ipblock, as rr_delete() already does, since it is not part of the record value. ITOUDP-8041 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"modify rr NAME a IP" and "show rr NAME a IP" had no layer3domain argument and ignored NDCLI_LAYER3DOMAIN / layer3domain= in ~/.ndclirc. When IP exists in more than one layer3domain the server cannot pick one and answered "A layer3domain is needed" with no way for the user to supply it.
They now take "layer3domain NAME" and the configured default, exactly like "create rr" and "delete rr". The server drops layer3domain after using it to resolve the ipblock, as rr_delete() already does, since it is not part of the record value.
ITOUDP-8041