Repository navigation
Conversation
ndcli -n adds dryrun=True to every call it makes. Updating calls pop it in the transaction wrapper; read-only calls are not wrapped in a transaction and got it passed through to the method, so e.g. "ndcli delete pool P -f -n" died in ippool_get_subnets() with "unexpected keyword argument 'dryrun'". A read-only call has nothing to roll back; drop the argument for it in TransactionProxy, the one place every RPC call goes through. ITOUDP-6303 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ndcli -n adds dryrun=True to every call it makes. Updating calls pop it in the transaction wrapper; read-only calls are not wrapped in a transaction and got it passed through to the method, so e.g. "ndcli delete pool P -f -n" died in ippool_get_subnets() with "unexpected keyword argument 'dryrun'".
A read-only call has nothing to roll back; drop the argument for it in TransactionProxy, the one place every RPC call goes through.
ITOUDP-6303