Repository navigation
Conversation
…ate-1.t 'list containers' grew a 'layer3domain: <name>' header; the two per-CIDR invocations in this file were updated for it but the 'list containers layer3domain default' one was missed. The ::/0 bug masked it because the test never reached that line.
0.0.0.0/0 and ::/0 both have address 0 and prefix 0, so the key (address, prefix, layer3domain_id) could not hold both in one layer3domain: creating the second one died with a raw MySQLdb.IntegrityError leaking the INSERT statement to the user. `version` is part of a block's identity and belongs in the key. It is appended rather than inserted so the existing (address, prefix, layer3domain_id) index prefix stays usable, and the index keeps its name -- Ipblock._set_parent() references it via USE INDEX (address). The migration only relaxes the constraint, so no existing row can violate it. ALGORITHM=INPLACE, LOCK=NONE makes the server refuse instead of falling back to a copying, locking ALTER. Running it on a database whose index was already widened by hand (ITOUDP-7795, uat) just rebuilds the same index. Originally written as 12 -> 13 on fix/ipblock-unique-version; master has used 13 for the pseudo user column since, hence 13 -> 14. ITOUDP-7795 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.