Repository navigation
Conversation
process_command() gets the output of shell lines and the expected lines as bytes, but stripped and matched them with str arguments. Any shell line with an expected output died with a TypeError, so such a line could not be used in a test at all. Only the drill checks of the pdns-output tests have one, and they need a running pdns-output. Use bytes throughout, including the fill value for missing lines. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_command() gets the output of shell lines and the expected lines as bytes, but stripped and matched them with str arguments. Any shell line with an expected output died with a TypeError, so such a line could not be used in a test at all. Only the drill checks of the pdns-output tests have one, and they need a running pdns-output.
Use bytes throughout, including the fill value for missing lines.
works until 2099 which I consider "good enough"