Repository navigation

Fix/security review round3 - #282

Merged

robdmac merged 26 commits into

mainfrom

fix/security-review-round3

Oct 16, 2026

Merged

Fix/security review round3#282
robdmac merged 26 commits into
mainfrom
fix/security-review-round3

Commits on Oct 12, 2026
- Security review round 1: token leak, edge scoping, CSRF, signing secret, egress default-deny
  
  robdmac
  and
  claude
  committed
  1da4285
- Security review step B: dashboard-scoped sandbox credentials for /internal routes
  
  robdmac
  and
  claude
  committed
  5bc7b00
- Security review step C: per-machine signed control plane → sandbox requests
  
  robdmac
  and
  claude
  committed
  8fb9582
- Desktop: remove baked VM tokens (per-boot signing key, no INTERNAL_API_TOKEN in VM)
  
  robdmac
  and
  claude
  committed
  3ac5681
- vz-helper: write all bytes to vsock (fix >8KB transfers being truncated)
  
  robdmac
  and
  claude
  committed
  bd792cf
- Security review round 2: OAuth state binding, policy arg bypasses, role checks, subscription scoping
  
  robdmac
  and
  claude
  committed
  69e4705
- Fix round 2 regressions: desktop OAuth host mismatch, GitHub filenames
  
  robdmac
  and
  claude
  committed
  3087050
- Security review round 3: unprivileged browser stack, owner-only dashboard secrets
  
  robdmac
  and
  claude
  committed
  816235a
Commits on Oct 13, 2026
Commits on Oct 15, 2026
- Desktop: deliver EGRESS_PROXY_ENABLED to the VM on the kernel command line
  
  robdmac
  and
  claude
  committed
  c32c099
- Sandbox: Chromium managed policy disables component updates and local AI model
  
  robdmac
  and
  claude
  committed
  fccd224
- Terminal: drop the "Connected to sandbox" banner
  
  robdmac
  and
  claude
  committed
  a72b160
- Edges to newly created blocks use real item IDs
  
  robdmac
  and
  claude
  committed
  e69d0ad
- e2e: run against the desktop app; tolerate a wrapped shell prompt
  
  robdmac
  and
  claude
  committed
  25fb084
- Fix round 3 review: loopback guard, fail-closed egress, browser stack isolation
  
  robdmac
  and
  claude
  committed
  50c5751
- Fix round 3 review: Discord guild binding, no user credentials to VMs, token rollout
  
  robdmac
  and
  claude
  committed
  1d98005
- Fix round 3 review: desktop CSPRNG fail-closed, non-blocking vz bridge, cancelled edges
  
  robdmac
  and
  claude
  committed
  7708cf4
- Fix Codex review: legacy sandbox secret revocation, delayed refresh rejection
  
  robdmac
  and
  claude
  committed
  c2910fb
- Sandbox: E79 error codes, copyright headers, identifier renames
  
  robdmac
  and
  claude
  committed
  206c068
- Control plane: E79 error codes, copyright headers, identifier renames
  
  robdmac
  and
  claude
  committed
  7259771
- Desktop, frontend: copyright headers, vz-helper identifier renames
  
  robdmac
  and
  claude
  committed
  857ef86
- Sandbox: stop browser processes with SIGTERM so x11vnc frees shared memory
  
  robdmac
  and
  claude
  committed
  b285b09

Navigation Menu

Repository navigation

Fix/security review round3 - #282

Fix/security review round3#282
robdmac merged 26 commits into
mainfrom
fix/security-review-round3

Commits on Oct 12, 2026

Security review round 1: token leak, edge scoping, CSRF, signing secret, egress default-deny

Security review step B: dashboard-scoped sandbox credentials for /internal routes

Security review step C: per-machine signed control plane → sandbox requests

Desktop: remove baked VM tokens (per-boot signing key, no INTERNAL_API_TOKEN in VM)

vz-helper: write all bytes to vsock (fix >8KB transfers being truncated)

Security review round 2: OAuth state binding, policy arg bypasses, role checks, subscription scoping

Fix round 2 regressions: desktop OAuth host mismatch, GitHub filenames

Security review round 3: unprivileged browser stack, owner-only dashboard secrets

Commits on Oct 13, 2026

Security review round 3 follow-up: verified browser ports, trusted profile handover, collaborator secret cleanup

Fix round 3 review findings: Drive/Calendar arg checks, full approval lists, tracking across reprovision

Fix round 3 validation findings: guest clock sync, browser profile/screenshot hardening, secret push targeting

Per-dashboard browser profiles; token cache prefers newest sandbox generation

Token cache follows the session that won provisioning

Commits on Oct 15, 2026

Desktop: deliver EGRESS_PROXY_ENABLED to the VM on the kernel command line

Sandbox: Chromium managed policy disables component updates and local AI model

Terminal: drop the "Connected to sandbox" banner

Edges to newly created blocks use real item IDs

e2e: run against the desktop app; tolerate a wrapped shell prompt

Fix round 3 review: loopback guard, fail-closed egress, browser stack isolation

Fix round 3 review: Discord guild binding, no user credentials to VMs, token rollout

Fix round 3 review: desktop CSPRNG fail-closed, non-blocking vz bridge, cancelled edges

Fix Codex review: legacy sandbox secret revocation, delayed refresh rejection

Sandbox: E79 error codes, copyright headers, identifier renames

Control plane: E79 error codes, copyright headers, identifier renames

Desktop, frontend: copyright headers, vz-helper identifier renames

Sandbox: stop browser processes with SIGTERM so x11vnc frees shared memory