Repository navigation
Fix/desktop on mac - #244
Merged
Merged
Conversation
…host control-plane route The native Virtualization.framework desktop backend boots systemd → /etc/rc.local (MININIT is inert), which never brought up networking and had no guest→host path. Fixes, all verified end-to-end: - Networking: NIC forced to eth0 (net.ifnames=0); rc.local leases via dhclient (no bogus -timeout flag); added isc-dhcp-client + iproute2 to the image. Guest now gets IP/route/DNS automatically at boot and reaches the internet. - Guest→host control plane: reverse-vsock forwarder in vz-helper (--reverse-port-forward 8787:8787) + guest socat + CONTROLPLANE_URL/INTERNAL_API_TOKEN in rc.local. Unlocks OAuth integration tools, approvals, and callbacks on desktop. Verified: guest→host /health 200, gateway 403 NOT_ATTACHED w/ valid PTY token, discovery 200 — over loopback only (nothing exposed on a NIC). - /debug/exec endpoint (orcabot CLI primitive): runs guest shell from the host. Gated by ORCABOT_DEBUG_EXEC=1 (desktop-only, off in prod) + a random per-boot token delivered via the root-only VM console; agents can neither read nor guess it. - orcabot-server PATH floor so child binaries (browser stack, agent CLIs) resolve when launched from a bare PID-1 environment — also fixes the "Reconnecting to browser". - Image staging stamps the source signature instead of trusting dest mtime (the rw disk image's mtime is bumped by the guest, which silently skipped re-staging). - build-images.sh: SKIP_KERNEL=1 reuses the prebuilt kernel for fast rootfs-only rebuilds. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
CheckAndHold (browser navigation) and the transparent/kernel path only consulted the allowlist, so permanently-denied and tracker domains slipped through there even though the CONNECT/HTTP proxy paths blocked them. Unify all paths behind a single decide() ladder (localhost → deny → allow → tracker → hold) with a permitted() helper, so every interception point makes the same decision. Adds a regression test covering deny/tracker (incl. user "Always Allow" overriding the tracker denylist). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
…de files) Root-anchored so they don't shadow tracked assets in subdirs (frontend/public/*.png, *.mp4, desktop icons). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.