Repository navigation
INFRA-726 — Upgrade GHA to Node.js 24 - #1
Merged
Merged
Conversation
Upgrade actions pinned to Node.js 20 (or older) to their Node.js 24-compatible releases. GitHub will force Node 24 on June 2, 2026 and remove Node 20 on September 16, 2026. Ticket: INFRA-726 Co-authored-by: Cursor <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b9f1726. Configure here.
setup-go v6 enables built-in Go module caching by default. Move checkout before setup-go so the cache can find go.mod, and remove the explicit actions/cache step to avoid dual-caching conflicts. Co-authored-by: Cursor <[email protected]>
Coverage Report for CI Build 26461449577Warning No base build found for commit Coverage: 88.583%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
Author
|
Addressed both BugBot findings in 3e97788:
Made with AI (model: claude-sonnet-4-20250514) |
go.mod declares go 1.18 as the minimum version and the codebase uses the `any` type alias (introduced in 1.18), so 1.17 builds fail with "undefined: any". Remove it from the matrix. Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Upgrade GitHub Actions to Node.js 24-compatible versions.
GitHub will force Node.js 24 as the default runner on June 2, 2026 and remove
Node.js 20 entirely on September 16, 2026.
Linear: https://linear.app/enginetravel/issue/INFRA-726
Changes
actions/checkout@v3@v6.0.2(SHAde0fac2e...)actions/setup-go@v3@v6.4.0(SHA4a360112...)actions/cache@v3@v5.0.5(SHA27d5ce7f...)Actions needing manual review
golangci/golangci-lint-action@v3— not in action-versions.jsonshogo82148/actions-goveralls@v1— not in action-versions.jsonUpstream blockers
None.
Made with AI (model: claude-sonnet-4-20250514)
Made with Cursor
Note
Low Risk
CI-only workflow changes with no application runtime impact; slower builds possible without cache, and two third-party actions may still need Node 24 validation.
Overview
Updates the Test workflow for Node.js 24–ready runners by pinning
actions/checkoutandactions/setup-goto v6 SHAs (instead of @V3 tags) and reordering steps so checkout runs before Go setup in both lint and test jobs.The test matrix no longer runs Go 1.17.x (only 1.18.x and 1.20.x), matching the module’s
go 1.18minimum. Theactions/cacherestore step for~/go/pkg/modis removed from the test job, so dependency caching in CI is no longer applied.TODO comments flag
golangci/golangci-lint-action@v3andshogo82148/actions-goveralls@v1for manual Node 24 verification because they are not listed inaction-versions.json.Reviewed by Cursor Bugbot for commit 56c62b7. Bugbot is set up for automated code reviews on this repo. Configure here.