You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
generated-output secret and absolute-user-path scan: pass
git diff --check: pass
hot-file diff: empty
Honest boundary
This is contract alignment, not a runtime replacement. It does not edit the live Convex/agent loop, deploy anything, add Pi AI to production, claim a no-key application demo, or promote NodeBenchAI from the registry's untracked command profile. The clean worktree intentionally had no installed application dependencies, so the existing full app typecheck/build were not rerun for this manifest/docs/generated-metadata-only delta.
This PR adds 10272 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC.
If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
splitting into 2-3 PRs along independent concerns
pre-discussing the architecture change in a GitHub Discussion before merge
Superseded by #592. The replacement preserves this brownfield contract alignment, uses the repository-required chore/<slug> branch and Conventional Commit title, declares the coordinated NodeKit concept dependency, and fixes Vercel preflight to typecheck the backend/convex project declared by convex.json. No force-push or deployment was performed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Aligns NodeBenchAI's current post-Phase-2 tree with the frozen NodeKit v1 contracts without moving runtime code or changing production behavior.
What changed
apiVersion/kind/specmanifests with canonical flatnodekit.repo/v1,nodeagent.application/v1, andnodeagent.pack/v1repo-local-nodebenchexplicitly authoritative while recordingnodeagent-nativeas the migration target.nodeagent/definition and config hash over the current 1,908-file authored surfacePolicyContextas a domain specialization, not a fork of the runtime policy contractValidation
Against the latest NodeKit v1 compiler:
ce762d645646cb409ea3e20e58517608ce921dc9262eae8aa3377847bfc4594fgit diff --check: passHonest boundary
This is contract alignment, not a runtime replacement. It does not edit the live Convex/agent loop, deploy anything, add Pi AI to production, claim a no-key application demo, or promote NodeBenchAI from the registry's
untrackedcommand profile. The clean worktree intentionally had no installed application dependencies, so the existing full app typecheck/build were not rerun for this manifest/docs/generated-metadata-only delta.