Repository navigation
[HELP-14]: Yarn removal - #129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mar-crespo
left a comment
There was a problem hiding this comment.
Just one main comment that we should address before merging, and one nit that is completely fine. Otherwise, great on the PR.
There was a problem hiding this comment.
I'm pretty sure this is a Typescript build cache. We should leave it out since this is only for local use and it'll end up giving people merge conflicts because their local cache might look different. Let me know if you need help removing it.
There was a problem hiding this comment.
This is good here for now, but let make sure we're breaking up PRs as much as possible so if anything goes wrong we can revert just the small change. Sorry this is super nitpicky for this, it's fine because I know we have all this cleanup to do on the quicks.
There was a problem hiding this comment.
Sounds good, I'll keep this in mind for the future. Thanks for the review Maribel!
References
Proposed Changes
package-lock.jsonlockfileREADME.md..env.examplefiles, and fixes a small bug with URL handling for hearts inbackend/config/urls.py.