Skip to content

[HELP-14]: Yarn removal - #129

Merged
ericguo202 merged 4 commits into
previewfrom
yarn-removal
Oct 6, 2026
Merged

ericguo202 merged 4 commits into
previewfrom
yarn-removal

Conversation

@ericguo202

Copy link
Copy Markdown
Member

References

  • Linear: HELP-14

Proposed Changes

  • Removes Yarn and regenerates the package-lock.json lockfile
  • Adds documentation for installation for both the frontend and backend in README.md.
  • Fixes small bugs and errors with both frontend and backend .env.example files, and fixes a small bug with URL handling for hearts in backend/config/urls.py.

@vercel

vercel Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
help Ready Ready Preview Oct 6, 2026 4:27pm UTC

Request Review

@linear

linear Bot commented Oct 4, 2026

Copy link
Copy Markdown

HELP-14

@raykong06 raykong06 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, doesn't seem like to large of a change other than the lock files. Reminder to update Hoagie Docs with updated setup and run instructions.

@mar-crespo mar-crespo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one main comment that we should address before merging, and one nit that is completely fine. Otherwise, great on the PR.

Comment thread frontend/tsconfig.tsbuildinfo Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this is a Typescript build cache. We should leave it out since this is only for local use and it'll end up giving people merge conflicts because their local cache might look different. Let me know if you need help removing it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Comment thread backend/config/urls.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good here for now, but let make sure we're breaking up PRs as much as possible so if anything goes wrong we can revert just the small change. Sorry this is super nitpicky for this, it's fine because I know we have all this cleanup to do on the quicks.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll keep this in mind for the future. Thanks for the review Maribel!

@ericguo202
ericguo202 merged commit 1dc44a7 into preview Oct 6, 2026
4 checks passed
@ericguo202
ericguo202 deleted the yarn-removal branch October 11, 2026 17:32
@ericguo202
ericguo202 restored the yarn-removal branch October 11, 2026 17:32
@ericguo202
ericguo202 deleted the yarn-removal branch October 11, 2026 17:34

This branch was successfully deployed

1 active deployment
Preview — a77e68dc Deployed Oct 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants