Repository navigation
feat(kinetics): too-few-points warning, intercept checks, 'Pseudo-first (initial drop)' model - #14
Merged
Merged
Conversation
…otes - The golden master compared the new model's A / A_se at rtol=1e-9; A_se differs by 3.6e-9 between the Windows build that wrote the JSON and Linux, so the test failed in CI. A, A_se and initial_drop_pct join the fragile parameter keys (statistics, flags and the selected model are still compared tightly). - Tab 2: the Zero-order intercept note fired on every decelerating run (its line always misses C0) and repeated the Pseudo-first warning, so that check is dropped. The PSO note is shown only when the straight line fits (R² >= 0.95); linear_intercept_check now also returns r2. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MIN_FIT_POINTSinformative points (t = 0 anchor not counted): AICc then over-penalises 2-parameter models and cannot evaluate 3-parameter ones. The summary gains ann (fitted)column.catlab.metrics.linear_intercept_check. A PFO line that misses the origin warns about a fast initial removal step and estimates its size (100·(1 − e^(−a))). A PSO mismatch is noted only when its straight line fits (R² ≥ 0.95).Review fixes on top of the original commits
A/A_sekeys were compared at rtol = 1e-9 andA_sediffers by 3.6e-9 between Windows and Linux; they join the fragile parameter keys. Existing golden values are unchanged (verified programmatically); only the new model's entries were added and no golden dataset's selected model changed.Verification
tests/synthetic_data.py); no experimental data in the tree or the branch history.ruff check/ruff format --checkclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
Generated by Claude Code