Repository navigation
test(ui): end-to-end AppTest tests for all 9 tabs; coverage floor in CI - #13
Merged
Merged
Conversation
…non-degenerate The Removal-tab test looked for children of type "imgs"; Streamlit 1.64 (what CI installs) reports "image", so the test failed on Linux. Accept both. The Arrhenius test uploaded the same file for 25 and 60 °C, so k was equal at both temperatures and Ea = 0; it only checked the columns. The 60 °C file is now faster and the test asserts Ea > 0. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_app_ui.py(markerui): drives the real Streamlit app withstreamlit.testing.v1.AppTest, with in-memory CSV/XLSX uploads.MODEL_NAMES; manual exclusion drops "points used" by one; aTime (h)header warns; a t=0 row leaves R² unchanged.--cov-fail-under=81.Review fixes on top of the original commits
"imgs"; Streamlit 1.64 (what CI installs) reports"image", so it failed on Linux. It now accepts both.Verification
171 tests pass; coverage of
app_ods.py18 % → 78 %, total 45 % → 83 % (floor 81 %);ruff check/ruff format --checkclean. No change to app code.🤖 Generated with Claude Code
https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
Generated by Claude Code