Repository navigation
style: format with ruff; lint with ruff in CI - #12
Merged
Merged
Conversation
CI installed the latest ruff. A new minor release can change the formatter's style, which would make `ruff format --check` fail on unrelated pull requests. Pin to ~=0.15.0 (the version the codebase was formatted with) in CI and in the dev extra. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff format .over the whole repo, in its own commit (8bd38ad), listed in.git-blame-ignore-revs.import a, bsplit, one test lambda →def, justified# noqa: E402where import order matters (set_page_configpatch in tests, BLAS thread pin in the validation harness).ruff check .andruff format --check .(strict, no--exit-zero) instead of flake8; ruff pinned to~=0.15.0so a new formatter style cannot break unrelated PRs.Verification
ast.dump), so it cannot change behaviour.tests/data/golden_fit.jsonuntouched.ruff check .→ 0 findings;ruff format --check .→ 20 files formatted; 155 tests pass; validation harness runs; app smoke test loads 9 tabs.Merge with a merge commit (not squash/rebase) so the hash in
.git-blame-ignore-revsstays valid.🤖 Generated with Claude Code
https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
Generated by Claude Code