Repository navigation
fix(app): CSV uploads work in every tab; header shows the real version - #11
Merged
Merged
Conversation
…e real version Every tab calls _load_kinetic_data on the same UploadedFile. read_csv left the cursor at the end, so on a CSV upload every tab after the first failed with "Cannot read file: Could not determine delimiter" (Excel was unaffected because openpyxl seeks itself). The loader now calls uploaded.seek(0) first. The page title and header said v3.5.3; both now use catlab.__version__. Tests: repeated CSV reads, an AppTest CSV upload with no "Cannot read file" error in any tab, and the header version. All three fail without the fix. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_kinetic_dataon the sameUploadedFile;read_csvleft the cursor at the end, so every tab after the first showed "Cannot read file: Could not determine delimiter". Excel was unaffected (openpyxl seeks itself). The loader now callsuploaded.seek(0)first.catlab.__version__.Tests
Three new tests in
tests/test_app_ods.py::TestRepeatedUploadReads— nine consecutive CSV reads, an AppTest CSV upload with no "Cannot read file" error in any tab, and the header version. All three fail onmainand pass with this change. Full suite: 155 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01GN1ANT89MKDjHRXcnjgSjo
Generated by Claude Code