Conversation
MrKeiKun
force-pushed
the
issue73-move-calc-skillratio
branch
from
September 25, 2026 08:13
a602c7c to
33a2ba9
Compare
MrKeiKun
force-pushed
the
issue73-move-calc-skillratio
branch
from
October 3, 2026 04:04
33a2ba9 to
0c5b7cc
Compare
Relocates the skill damage ratio calculation from battle.c to skill.c, where it belongs. Part of issue HerculesWS#73.
Style-only cleanup of the function moved in the previous commit: space after control keywords, no padding inside parentheses, space after commas and around binary operators, space before braces, and explicit NULL comparisons for pointer checks.
MrKeiKun
force-pushed
the
issue73-move-calc-skillratio
branch
from
October 3, 2026 05:54
0c5b7cc to
63af76f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Moves
battle_calc_skillratio()frombattle.ctoskill.casskill_calc_skillratio(), and moves its interface entry frombattle->toskill->.Two commits, so the move can be reviewed separately from the formatting:
Issues addressed: #73