Conversation
FluxCP's own access/change logs capture $_SERVER['REMOTE_ADDR'] from the web request, which can be IPv6 regardless of Hercules (which is IPv4-only). The varchar(15) columns were sized for IPv4 dotted-quad only and truncate or fail on IPv6 addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluxCP logs
$_SERVER['REMOTE_ADDR']from the web request in several logindb tables (cp_loginlog, cp_pwchange, cp_resetpass, cp_emailchange, cp_ipbanlog), and this can be IPv6 even though Hercules itself is IPv4-only. Thevarchar(15)columns were sized for IPv4 only, causing truncation/failures on IPv6 addresses. This widens them tovarchar(45)via new ALTER TABLE schema migrations.Fixes #48
Thank @dastgirp