BuchhaltungsButler adapter: real endpoints, required filters, verified live - #829
Merged
Merged
Conversation
…d live The adapter was written from memory and never run. Checked against the vendor's OpenAPI document (app.buchhaltungsbutler.de/docs/api/v1.de.json) and a live tenant: - list_customers / list_suppliers called /customers/get and /suppliers/get, which do not exist (the web app answers with its HTML 404 page). They are debtors and creditors: /settings/get/debtors and /settings/get/creditors. - list_receipts needs list_direction (inbound/outbound); without it the API answers 400 "invalid list_direction specified". - list_postings needs date_from and date_to (400 otherwise). - list_accounts takes no paging. - New: list_posting_accounts (chart of accounts) and list_cost_locations. - Filters the API offers (payment status, counterparty, accounts, order). - Instructions: drop "unverified", explain the 401 vs HTML-404 signals, the required filters, the 100 requests/minute limit, and that the Basic Auth fields hold the API client id and secret, not the BuchhaltungsButler login. The body stays JSON: the API accepts it, and form encoding turns numbers into strings that /settings/get/postingaccounts refuses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A paying Cloud customer reported HTTP 404 on every BuchhaltungsButler tool. The adapter (from #642) had never been run against the API.
Checked against the vendor's OpenAPI document (
app.buchhaltungsbutler.de/docs/api/v1.de.json) and the customer's live tenant (read-only calls, with their permission):/customers/get(does not exist, HTML 404)/settings/get/debtors/suppliers/get(does not exist)/settings/get/creditorslist_directionlist_directionrequired (inbound/outbound) + payment status, counterparty, invoice numberdate_from/date_torequired + account, posting account, status, orderAll 8 tools return
success: truethrough the production RestEngine against the live tenant. JSON bodies are kept: the API accepts them, and form encoding sends numbers as strings, which/settings/get/postingaccountsrejects.Instructions now explain the 401 (bad client id/secret) vs HTML 404 (unknown path) signals, the required filters, the rate limit, and that the Basic Auth fields hold the API client id and secret, not the BuchhaltungsButler login.