SoF conformance: ViewDefinition search parameters and fixture housekeeping

[andyguz17]

Summary

ViewDefinition search parameters (#570)

• Add data/sql-on-fhir-search-parameters.json: the 17 ViewDefinition SearchParameters (url, name, status, date, version, identifier, title, description, publisher, jurisdiction, resource, profile, and the context* family) copied from the current official SQL-on-FHIR IG build (hl7.fhir.uv.sql-on-fhir 3.0.0-ballot) under their official core-namespace canonicals (http://hl7.org/fhir/SearchParameter/ViewDefinition-{code}). The file is loaded through the existing custom-file mechanism (any data/*.json not matching search-parameters-*.json), so the verbatim HL7 spec artifacts data/search-parameters-r*.json and the loader's production code are untouched.
• One deliberate, documented deviation from the published build: the two composite parameters (context-type-quantity, context-type-value) reference their components via legacy uv/sql-on-fhir canonicals upstream, which would never resolve in the registry (components would be silently skipped and the composites would index nothing). Our copy uses the core canonicals for those four component.definition values.
• New tests: loader/registry survival tests per FHIR version (all 17 registered, active, retrievable by code and canonical, benign collision with the embedded fallback), an extractor-level test proving the composite context parameters actually index a matching useContext, and an integration suite (crates/rest/tests/view_definition_search_params.rs, 25 tests) covering GET /ViewDefinition?url|name|status|date|_lastUpdated, the CapabilityStatement entry (full interaction set + advertised searchParams; Library full interaction set), and a $reindex round trip restoring searchability of pre-existing ViewDefinitions.
• Docs: the REST README notes that pre-existing ViewDefinitions require $reindex after upgrading to become searchable by the new parameters; the HFS README's data-directory tree lists the new file.

Conformance fixture housekeeping (#571)

• Re-sync the SQL-on-FHIR conformance fixtures from upstream (byte-verbatim). Only tests/repeat.json changed (upstream fixture-data fix: required Questionnaire.status added, an invalid childless group item changed to display). No fixtures added or removed.
• Rename the fixture directory from crates/sof/tests/sql-on-fhir-v2/ to the version-neutral crates/sof/tests/sql-on-fhir/, as decided in Decide: keep or rename crates/sof/tests/sql-on-fhir-v2 (path stability vs version-neutral name) #718: the fixtures track the current spec (3.0.0-ballot), not v2. Pure git mv (all 22 fixtures byte-identical), all path references updated, and the README's path-stability note removed in the same change. The one historical citation to the old FHIR/sql-on-fhir-v2 GitHub repository (a PR reference in emit.rs) is kept as provenance.
• Pin the fixture JSON files to LF in .gitattributes so byte-verbatim comparison against upstream stays clean on Windows checkouts.
• Conformance pass counts are unchanged after the re-sync and rename: 132/144 on SQLite, PostgreSQL, and MongoDB (PASS_FLOOR stays 132; the 12 remaining failures are the documented engine gap).

Testing

• cargo fmt --all -- --check, cargo clippy -p helios-fhir -p helios-rest -p helios-persistence --all-targets -- -D warnings
• cargo test -p helios-fhir search (default + --all-features), cargo test -p helios-persistence --lib search::extractor, cargo test -p helios-rest (full suite), cargo test -p helios-sof --tests
• Conformance suites on SQLite, PostgreSQL, and MongoDB (Docker): 132/144 each, floor met — re-verified after the directory rename
• Key suites re-run after merging main back into the branch: all green
• Manual smoke against a live server: create + search by url/name/status/date/_lastUpdated, CapabilityStatement entry verified

Fixes #570
Fixes #571
Closes #718

[codecov]

Codecov Report

❌ Patch coverage is 96.59091% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
crates/fhir/src/search/loader.rs	97.05%	3 Missing ⚠️
crates/persistence/src/search/extractor.rs	95.94%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

[smunini]

Tracking for the upstream composite-canonical inconsistency that scripts/sync-sof-search-params.py patches around (the composites' component.definition values reference legacy uv/sql-on-fhir canonicals no published SearchParameter declares):

• GitHub issue: Composite ViewDefinition SearchParameters reference components via legacy uv/sql-on-fhir canonicals that no published SearchParameter declares HL7/sql-on-fhir#403
• chat.fhir.org thread in #analytics on FHIR: https://chat.fhir.org/#narrow/stream/179219-analytics-on-FHIR/topic/ViewDefinition.20SearchParameter.20canonicals (also asks whether post-ballot feedback should be moving to HL7 Jira)

Once fixed upstream, the script's canonical rewrite becomes a no-op and data/sql-on-fhir-search-parameters.json becomes a fully verbatim copy of the IG package.

https://claude.ai/code/session_01CktNg2DJpWsPFANE1VevR9