Skip to content

Fix stale query operators after changing search parameters - #713

Merged
smunini merged 3 commits into
mainfrom
bugfix/627-query-builder-stale-modifier
Aug 27, 2026
Merged

Fix stale query operators after changing search parameters#713
smunini merged 3 commits into
mainfrom
bugfix/627-query-builder-stale-modifier

Conversation

@Gordex2014

Copy link
Copy Markdown
Contributor

Summary

  • Reconcile modifiers and comparator prefixes whenever a search parameter resolves to a different type, including plain conditions, forward chains, and _has rows.
  • Keep unknown and ambiguous parameters permissive while applying the complete supported modifier matrix to known parameter types.
  • Block Run, Save, Copy, Enter, saved-query runs, and deep-link runs until asynchronous catalog resolution leaves the controls, URL, and narration consistent.
  • Handle catalog failures and stale responses safely, preserve unchanged URL spelling, and cancel deferred auto-runs when the user edits the builder.

Test plan

  • cargo build -p helios-hfs --features ui
  • cargo test -p helios-ui
  • Full Chromium query-builder E2E suite
  • Chromium Natural Language Search and Resources E2E suites
  • Manual regression check for changing name:contains to gender without automatically running the query

Closes #627

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

smunini
smunini previously approved these changes Aug 27, 2026
…der-stale-modifier

# Conflicts:
#	crates/ui/assets/saved-queries.js
…der-stale-modifier

# Conflicts:
#	crates/ui/assets/saved-queries.js
@smunini
smunini merged commit 6075312 into main Aug 27, 2026
25 checks passed
@smunini
smunini deleted the bugfix/627-query-builder-stale-modifier branch August 27, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query builder keeps :contains after changing name to gender

2 participants