Fix BOM consumer POM publication - #5
Merged
Merged
Conversation
remdui
marked this pull request as ready for review
August 20, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flatten-maven-pluginwithupdatePomFile=truewhile retainingresolveCiFriendliesOnly${revision}placeholdersfeatureframework-bomand verifies it supplies thefeatureframework-theme-apiversionWhy
featureframework-bomandfeatureframework-parentboth usepompackaging and CI-friendly${revision}versions. The Flatten plugin was generating flattened POMs, but withoutupdatePomFile=truea POM-packaging project is not guaranteed to use that flattened POM for install/deploy. That can leave downstream consumers with a published POM whose parent/version still contains${revision}.This matters now that ServerFeatures and ProxyFeatures are moving to application-level FeatureFramework BOM imports for strict dependency convergence.
Validation strategy
The new
scripts/verify-bom-consumer.shtests the artifact exactly at the Maven consumer boundary rather than only inspecting source configuration:featureframework-parentandfeatureframework-bominto a fresh temporary Maven local repository;${revision};featureframework-bomat the current version and declarefeatureframework-theme-apiwithout a version;The release workflow runs this gate before the deploy step, preventing a future tag from publishing an unusable BOM unnoticed.
Compatibility
No runtime Java/API behavior changes. This only changes Maven publication metadata and release validation.
Validation
main(483e894994766dd73200845a55439025144fb879)bash -npasses for the new scriptfeatureframework-theme-api:1.5.1${revision}probeThe PR remains draft until the current-head runtime gates complete.