Skip to content

chore: use 256 bits instead of 512 for BLAKE2b hash #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HastD merged 1 commit into from
Oct 17, 2026
Merged

chore: use 256 bits instead of 512 for BLAKE2b hash #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ SPDX-License-Identifier: Apache-2.0 OR MIT

# Changelog

## [Unreleased]

- Use 256-bit BLAKE2b hash instead of default 512 bits.

## [v0.6.1] - 2026-08-23

- Grant the privileged inner script the additional capabilities `CAP_SYS_NICE`
Expand Down Expand Up @@ -231,6 +235,7 @@ Rewrote script in Python. ([#1](https://github.com/HastD/run0edit/pull/1))

- Initial release.

[Unreleased]: https://github.com/HastD/run0edit/compare/v0.6.1...HEAD
[v0.6.1]: https://github.com/HastD/run0edit/compare/v0.6.0...v0.6.1
[v0.6.0]: https://github.com/HastD/run0edit/compare/v0.5.10...v0.6.0
[v0.5.10]: https://github.com/HastD/run0edit/compare/v0.5.9...v0.5.10
Expand Down
2 changes: 1 addition & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ conf_data.set('LIBEXECDIR', libexecdir)
conf_data.set('SYSCONFDIR', sysconfdir)

main_script = configure_file(
input: 'run0edit_main.py.in',
input: 'run0edit_main.py',
output: 'run0edit_main.py',
configuration: conf_data,
)
Expand Down
7 changes: 3 additions & 4 deletions run0edit_main.py.in → run0edit_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@

__version__: Final[str] = "@VERSION@"
INNER_SCRIPT_PATH: Final[str] = "@LIBEXECDIR@/run0edit/run0edit_inner.py"
INNER_SCRIPT_B2: Final[str] = "\
7d215d913fbc27ace618e1354a6dadcc8277a3eb77dfa38a243d6a5e76e0e350afd5143a0b6bb34059b089cef19a957340cb2c1af4040c0ea489af31875bfb05"
INNER_SCRIPT_B2: Final[str] = "21f7a46ca9a765179bca501703f8de12569a6e19fbe248e25e8ba3f612c636af"
DEFAULT_CONF_PATH: Final[str] = "@SYSCONFDIR@/run0edit/editor.conf"

CAPABILITY_BOUNDING_SET: Final[list[str]] = [
Expand Down Expand Up @@ -83,10 +82,10 @@


def validate_inner_script() -> bool:
"""Ensure inner script has expected BLAKE2 hash."""
"""Ensure inner script has expected BLAKE2b hash."""
try:
with open(INNER_SCRIPT_PATH, "rb") as f:
file_hash = hashlib.blake2b(f.read())
file_hash = hashlib.blake2b(f.read(), digest_size=32)
except OSError:
return False
return file_hash.hexdigest() == INNER_SCRIPT_B2
Expand Down
4 changes: 2 additions & 2 deletions test/test_run0edit_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ def test_inner_script_path(self):
self.assertEqual(run0edit.INNER_SCRIPT_PATH, "/usr/libexec/run0edit/run0edit_inner.py")

def test_inner_script_b2(self):
"""INNER_SCRIPT_B2 should equal BLAKE2 hash of inner script"""
"""INNER_SCRIPT_B2 should equal BLAKE2b hash of inner script"""
with open("run0edit_inner.py", "rb") as f:
file_hash = hashlib.blake2b(f.read())
file_hash = hashlib.blake2b(f.read(), digest_size=32)
self.assertEqual(file_hash.hexdigest(), run0edit.INNER_SCRIPT_B2)

def test_default_conf_path(self):
Expand Down