Skip to content

Fix Docker Hub workflow login #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalebbroo merged 1 commit into from
Aug 30, 2026
Merged

Fix Docker Hub workflow login #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/publish-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,21 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v4

- name: Verify Docker Hub publishing credential
if: github.event_name != 'pull_request'
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
run: |
if [ -z "$DOCKERHUB_TOKEN" ]; then
echo "::error::Add the DOCKERHUB_TOKEN repository secret before publishing."
exit 1
fi

- name: Sign in to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@v4
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
username: kalebbroo
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Generate image metadata
Expand Down
7 changes: 4 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@ docker.io/kalebbroo/runpod-serverless-aitoolkit:latest
docker.io/kalebbroo/runpod-serverless-aitoolkit:sha-<full-git-commit>
```

Configure these GitHub Actions repository secrets before merging the workflow:
Configure this GitHub Actions repository secret before publishing:

- `DOCKERHUB_USERNAME`: `kalebbroo`
- `DOCKERHUB_TOKEN`: a Docker Hub personal access token with Read & Write permission

Create the `kalebbroo/runpod-serverless-aitoolkit` Docker Hub repository first. Do not store a Docker Hub password or token in the repository. Use the immutable `sha-<full-git-commit>` tag in the RunPod template; `latest` is a convenience tag for inspection and manual testing.
The public Docker Hub username `kalebbroo` is configured directly in the workflow and does not need to be stored as a secret.

The first successful push creates `kalebbroo/runpod-serverless-aitoolkit` if it does not exist. Do not store a Docker Hub password or token in the repository. Use the immutable `sha-<full-git-commit>` tag in the RunPod template; `latest` is a convenience tag for inspection and manual testing.

The workflow publishes BuildKit provenance and an SBOM with release images and uses the GitHub Actions cache for subsequent builds.

Expand Down