Transaction log deletion is database-wide on RocksDB; table-scoped requests are rejected - #618
Transaction log deletion is database-wide on RocksDB; table-scoped requests are rejected#618cb1kenobi wants to merge 3 commits into
Conversation
delete_transaction_logs_before now rejects table-scoped requests on RocksDB (HarperFast/harper#2049), and the deprecated delete_audit_logs_before always errors there since it requires table. Co-Authored-By: Claude Fable 5 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the database transaction documentation to deprecate the delete_audit_logs_before operation and introduces documentation for the delete_transaction_logs_before operation, detailing its behavior on RocksDB and LMDB. The feedback suggests adding a dedicated ### Transaction Log Operations section header to improve the document's structure and clarity.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-618 This preview will update automatically when you push new commits. |
Co-Authored-By: Claude Fable 5 <[email protected]>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-618 This preview will update automatically when you push new commits. |
…ecords Co-Authored-By: Claude Fable 5 <[email protected]>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-618 This preview will update automatically when you push new commits. |
1 participant
Companion to HarperFast/harper#2064 (fixes HarperFast/harper#2049 — RocksDB: table-scoped delete_transaction_logs_before destroys the entire database's transaction log).
Updates
reference/database/transaction.md:delete_transaction_logs_beforesection: on RocksDB (the default engine) deletion is database-wide because all tables in a database share one transaction log; as of v5.2.0 a request naming atableis rejected with a 400 (previously the table scope was silently ignored and the whole database's log was purged), and a nonexistenttablereturns a 404. On LMDB,tablescopes deletion to that table, unchanged.delete_audit_logs_beforethat it is deprecated in favor ofdelete_transaction_logs_before, and that on RocksDB it always errors since it requirestable.npm run buildandnpm run format:checkpass locally.Generated by Claude (Fable 5).
🤖 Generated with Claude Code