test(terminal): decouple lifecycle coverage from legacy routes

[Nima-Naderi]

Summary

• Decouple terminal lifecycle tests from legacy HTTP routes before the workspace gateway cutover.
• Keep deletion ordering, layout reconciliation, interrupted-runtime recovery, and tombstone cleanup covered at their owning store/registry boundaries.
• Let the following gateway layer retire /api/terminal/sessions/** without leaving stale route-coupled assertions.

Stack

Layer 3 of 10 in the terminal workspace stack.

• Base: feat(terminal-runtime): add project-scoped workspace foundation #1416
• Next: feat(gateway): cut over to shared terminal workspaces #1431
• Stack root: feat(terminal-runtime): add workspace contracts and persistence #1418 on fix(terminal): add durable session lifecycle UI #1476

Validation

• pnpm install --offline --frozen-lockfile
• Gateway TypeScript check
• Pattern scan: 0 violations
• Focused lifecycle/adapter tests: 18 passed
• Diff hygiene

Invariants

• Source of truth: production behavior is unchanged; lifecycle state remains owned by the existing terminal layout store and runtime registry.
• Lock/transaction scope: the deletion test exercises the same per-session lifecycle lock and begin/delete/complete ordering as production.
• Acceptable orphan states: unchanged; this PR only relocates test orchestration.
• Auth source of truth: unchanged; no route or authentication behavior changes.
• Deferred scope: canonical workspace route behavior remains in feat(gateway): cut over to shared terminal workspaces #1431 and later layers.

[Nima-Naderi]

@greptileai please re-review the latest commit

[Nima-Naderi]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(native): migrate terminal workspace clients #1441
• feat(desktop): cut over terminal workspace clients #1440
• feat(desktop): migrate terminal workspace runtime #1437
• feat(shell): cut over terminal workspace clients #1434
• feat(cli): use shared terminal workspace tabs #1432
• feat(gateway): cut over to shared terminal workspaces #1431
• test(terminal): decouple lifecycle coverage from legacy routes #1503 👈 (View in Graphite)
• feat(terminal-runtime): add project-scoped workspace foundation #1416
• feat(terminal-runtime): add workspace contracts and persistence #1418
• fix(terminal): add durable session lifecycle UI #1476
• fix(terminal): make session deletion authoritative #1426
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Greptile Summary

The PR decouples terminal lifecycle tests from legacy HTTP routes while retaining coverage at the layout-store, runtime-registry, and adapter boundaries.

• Exercises deletion locking, tombstone transitions, registry deletion, and layout reconciliation directly through the owning store.
• Exercises interrupted-runtime recovery through the registry and verifies tombstone cleanup separately.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
tests/gateway/terminal-window-layout-store.test.ts	Replaces legacy route-level deletion orchestration with direct lifecycle-store operations while preserving real-store reconciliation assertions.
tests/gateway/user-systemd-zellij-adapter.test.ts	Replaces route-driven recovery with direct registry recovery and explicit tombstone cleanup while retaining adapter and persisted-state assertions.

_{Reviews (2): Last reviewed commit: "test(terminal): decouple lifecycle cover..." | Re-trigger Greptile}