Repository navigation
Hamed R. - #3
Hamed R.#3HamedRazizadeh-hub wants to merge 1 commit into
Conversation
| @@ -0,0 +1,64 @@ | |||
| body { | |||
There was a problem hiding this comment.
Look at that!
You already added the CSS that were not part of this tasks. Did you already study it?
| <p>Frontend Developer Student</p> | ||
|
|
||
| <img | ||
| src="https://media.licdn.com/dms/image/v2/D4D03AQHJh1pgR0V6xg/profile-displayphoto-scale_400_400/B4DZ386YA5HkAk-/0/1778064656767?e=1779926400&v=beta&t=lz9OJBRjDMcdJ9Ta94DItBx7vRMNvRnZscn-KJOX7WM" |
There was a problem hiding this comment.
How would you show this image if it was saved in the folder?
| src="https://media.licdn.com/dms/image/v2/D4D03AQHJh1pgR0V6xg/profile-displayphoto-scale_400_400/B4DZ386YA5HkAk-/0/1778064656767?e=1779926400&v=beta&t=lz9OJBRjDMcdJ9Ta94DItBx7vRMNvRnZscn-KJOX7WM" | ||
| alt="profile-picture" | ||
| /> | ||
| <button id="theme-toggle" type="button">Toggle Theme</button> |
There was a problem hiding this comment.
Very cool feature and in combination with the JS DOM Manipulation!
|
|
||
| <main> | ||
| <section> | ||
| <h2>about Me</h2> |
There was a problem hiding this comment.
nitpick: Maybe the capital letter would fit better?
| <h2>about Me</h2> | |
| <h2>About Me</h2> |
| </header> | ||
|
|
||
| <main> | ||
| <section> |
There was a problem hiding this comment.
Why did you choose an section? Do you think that other tags could be used here?
| }); | ||
|
|
||
| contactForm.addEventListener("submit", function (event) { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Maybe move the const formMessage inside the listener is better, then you don't create it in global level.
rafasilpereira
added
the
Reviewed
|
|
||
| <img | ||
| src="https://media.licdn.com/dms/image/v2/D4D03AQHJh1pgR0V6xg/profile-displayphoto-scale_400_400/B4DZ386YA5HkAk-/0/1778064656767?e=1779926400&v=beta&t=lz9OJBRjDMcdJ9Ta94DItBx7vRMNvRnZscn-KJOX7WM" | ||
| alt="profile-picture" |
There was a problem hiding this comment.
alt property is used as a description for the image when is not loaded, and more important is used for screen readers for accessibility. Review this text ;)
2 participants
No description provided.