Repository navigation
Week 1 assignment: interactive portfolio page with semantic HTML, for… - #2
Open
dianadenwik wants to merge 1 commit into
Open
dianadenwik wants to merge 1 commit into
dianadenwik wants to merge 1 commit into
Conversation
…ms, and DOM manipulation
| height="400" | ||
| alt="Young woman works on a computer" | ||
| /> | ||
| <button id="theme-toggle" type="button">🌙 Dark Mode</button> |
There was a problem hiding this comment.
This button is not working. Is a nice feature, but you are not using CSS (yet)
| src="https://plus.unsplash.com/premium_photo-1664301969414-d8435c2b91bb?fm=jpg&q=60&w=3000&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1yZWxhdGVkfDE2fHx8ZW58MHx8fHx8" | ||
| width="400" | ||
| height="400" | ||
| alt="Young woman works on a computer" |
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>My First Web Page</title> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
Very good division and semantic HTML! header, main and footer
| const button = document.querySelector("#theme-toggle"); | ||
|
|
||
| button.addEventListener("click", function () { | ||
| document.body.classList.toggle("dark-mode"); |
There was a problem hiding this comment.
Your are add this class, but it's not changing to dark. How would you make it work?
rafasilpereira
left a comment
rafasilpereira
left a comment
There was a problem hiding this comment.
Oops, you forgot the screenshot of your DevTools :S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ms, and DOM manipulation