Skip to content

Prepare Nightly 1.4.5 - #145

Merged
bermanto merged 1 commit into
mainfrom
release/nightly-1.4.5
Oct 12, 2026
Merged

bermanto merged 1 commit into
mainfrom
release/nightly-1.4.5

Conversation

@bermanto

@bermanto bermanto commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Prepare signed Nightly 1.4.5 from the change merged on main since 1.4.4.

Contents of 1.4.5:

  • Route static file directories through the Worker first #144: /assets/*, /fonts/*, /icons/*, and /sounds/* run the Worker first. A missing file
    returns 404 with Cache-Control: no-store, not the app page. Hashed /assets/ files keep the
    one-year immutable cache. New installations and every update add these routes.

The 1.4.4 changelog says that a missing script or style returns 404. That was not true in
production, because Cloudflare served the app page before the Worker. The 1.4.4 section stays as
published in the signed 1.4.4 release, and the 1.4.5 entry states the correction.

No database migration and no database compatibility change. The canonical specification is already
updated (HQBase/hqbase-site#62). #139 is still not included; #137 has no reply.

Effect on the next update: the routes take effect when the 1.4.5 Worker is deployed. A page that
still runs 1.4.4 or earlier then gets 404 for its removed files instead of HTML. A 1.4.4 page
reloads once after that load failure and then gets the current files.

Test plan after publication: update the installed desktop app from 1.4.4 to 1.4.5 with DevTools
open (Console and Network with Preserve log), then open Settings and the message editor. Also
check GET /assets/<missing>.js returns 404.

Risk: low to moderate. Every request to these four directories now goes through the Worker. Staging
E2E for #144 checked both the 404 and the immutable cache of the real entry script on Cloudflare.
Stable stays 1.4.0.

Validation:

  • pnpm check: pass. 988 unit tests pass and 2 are skipped. 226 Worker integration tests pass.
    Coverage, architecture, generated API, and production build pass.
  • pnpm deploy:dry-run: pass.
  • pnpm test:pwa: pass.
  • pnpm audit --prod: no known vulnerabilities.
  • extractReleaseNotes(CHANGELOG.md, "1.4.5") returns the expected item.
  • Staging E2E passed for the Route static file directories through the Worker first #144 commit 32b8484:
    run 38262991505. This PR changes
    only the version and the changelog. The signed release workflow runs its own staging gate on the
    final archive before publication.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Missing files requested from asset, font, icon, and sound paths now return a 404 instead of the app page.
  • Documentation
    • Added a changelog entry documenting the fix and noting that requests to these paths count as Worker requests.

Set the version to 1.4.5 and add the release notes for the static file
routing fix (#144). The 1.4.4 notes stay as published in the signed
release; the 1.4.5 notes state that the 1.4.4 404 change did not apply.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eff2eac0-cf3d-4198-a08c-2a9a116fc62d

📥 Commits

Reviewing files that changed from the base of the PR and between af32069 and 5794137.


📒 Files selected for processing (2)
  • CHANGELOG.md
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The changelog adds a 1.4.5 entry describing how missing files in four asset directories are handled. The package version changes from 1.4.4 to 1.4.5.

Changes

Release Metadata

Layer / File(s) Summary
Document the 1.4.5 release
CHANGELOG.md, package.json
The changelog describes the missing-file response for /assets/, /fonts/, /icons/, and /sounds/. The package version changes to 1.4.5.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Low

Suggested reviewers: awizemann, commandduck


Merge Risk: ⚪ Minimal · up to 57941

This update changes release metadata and notes only; no actionable user-facing or operational risk is identified.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the release-preparation change for version 1.4.5 and matches the pull request objectives.
Description check Passed The description explains the version change, changelog content, scope, risks, compatibility impact, and validation results. It does not use the template headings exactly, but it covers the required Su…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bermanto
bermanto merged commit 62bf075 into main Oct 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant