Repository navigation
fix: use dc:creator instead of author for item authors - #455
Merged
Merged
Conversation
github-actions
Bot
added
bug
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 83.20% 83.20%
=======================================
Files 11 11
Lines 786 786
Branches 133 133
=======================================
Hits 654 654
Misses 86 86
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Guts
requested changes
Oct 23, 2026
RSS 2.0 spec requires <author> to be an email address; the dc namespace is already declared and <dc:creator> is the correct element for names. - Change <author> to <dc:creator> in rss.xml.jinja2 template - Update XSL HTML preview to read dc:creator and managingEditor - Add test verifying dc:creator usage
Zerthick
force-pushed
the
fix/dc-creator-for-authors
branch
from
October 25, 2026 20:26
7c34564 to
a9edbf7
Compare
- escape author names in template (consistent with title and managingEditor) - fold dc:creator assertions into test_simple_build_complete and drop dedicated test module
|
Contributor
Author
|
Done, rebased on main, applied the |e filter on the author names, and moved the dc:creator assertions into test_simple_build_complete in test_build.py. Let me know if anything else is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
<dc:creator>instead of<author>for item authors in the RSS 2.0 feed.The RSS 2.0 spec requires
<author>to be an email address. Human-readable names should use<dc:creator>from the Dublin Core namespace (which is already declared in the feed).Changes
<author>to<dc:creator>inrss.xml.jinja2templatedc:creator(items) andmanagingEditor(channel)<dc:creator>usage and absence of<author>in itemsSplit from: #451