Repository navigation
Export OverlayInsetProvider for apps without a GrytProvider (GRYT-1784) - #293
Merged
Merged
Conversation
The client themes itself and never mounts GrytProvider, so it had no way to pass overlayInsetTop. OverlayInsetProvider sets the inset alone, with no wrapper element and no tooltip provider of its own. It's on the root and the gryt-provider subpath, and the changeset says so. Co-Authored-By: Claude Opus 5.5 <[email protected]>
A component beside plain exports trips react-refresh's warning twice, and the repo's lint caps warnings at 114. The context and hook go back to overlayInset.ts; the provider lives in OverlayInsetProvider.tsx. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #292, before it's released. The Gryt client themes itself and never mounts
GrytProvider, sooverlayInsetTophad nowhere to go there. Wrapping the app inGrytProviderwould add a wrapperdivat the root and change every tooltip's hover delay.OverlayInsetProvider({ top })sets the inset and nothing else. It's exported from the root and from@gryt/ui/gryt-provider, whichentries.test.tsrequires.overlayInset.tsbecomes.tsxwith"use client", as the entries test also requires of an interactive module.overlay-insetchangeset gets one more sentence, so this ships in the same patch as Keep popups out of a title bar the app draws (GRYT-1784) #292.tsc, eslint and vitest (139) pass.Vikunja: GRYT-1784
🤖 Generated with Claude Code