Repository navigation
A server setting for other servers' emoji, off by default (GRYT-1660) - #280
Merged
Merged
Conversation
Messages only show images from their own server now (client#791). This adds the owner's switch for the one exception: other Gryt servers' custom emoji. It's off by default, because the emoji loads from the other server, which then sees the address of everyone reading. external_emojis in server_config, externalEmojis in the settings patch and view, and external_emojis in server_info for clients to read. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages now only show images from their own server (Gryt-chat/client#791). This adds the owner's switch for the one exception, other Gryt servers' custom emoji. It's off by default, because such an emoji loads from the other server, which then sees the address of everyone who reads the message. That's the opt-in the task asked for.
What changes:
server_config.external_emojis INTEGER NOT NULL DEFAULT 0, added by the samehasColumnmigration asvideo_profiles.externalEmojisin the settings patch (socket and management) and insettingsView.server_info.external_emojis, for clients to read.src/settings/externalEmojis.test.tscovers the default, turning it on and off, a patch that leaves it out, and a value that isn't a boolean.What to look at:
src/dbis review-required. The diff there is one column, one migration line and one field in the row mapper.0, the opposite ofvideo_profiles. Existing servers come up with it off.The client half, the switch in server settings and the picker, comes next and reads
external_emojis.🤖 Generated with Claude Code