Repository navigation
Keep a card's short banner choice (GRYT-1665) - #279
Merged
Merged
Conversation
Card styles can carry bannerSize: "short" now, and the server kept only the fields it knew, so the choice would have been dropped on save. Tall is the default and is left out, like every other default. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Members can now pick a short banner on their card (Gryt-chat/ui#266), which stores
bannerSize: "short"in the card style. The server keeps only the style fields it knows, so without this the choice would be dropped on save. Tall is the default and is left out, like every other default. Any other value is dropped.A test covers the short value, the tall default and a bad value. The banner box the server stores (960×492) doesn't change.
🤖 Generated with Claude Code