Repository navigation
Tell the uploader when the worker refuses their avatar or banner (GRYT-1667) - #275
Merged
Merged
Conversation
…T-1667) Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #274 a refused avatar or banner never applies, and the member keeps the old one. But the uploader wasn't told anything: their upload just never showed up.
applyWhenSettledsees a refusal, it sendsprofile:media-refused { purpose, fileId }to every socket the uploader has open. The words are in the client (client PR alongside).emitToMember()insocket/utils/server.tsdoes the sending, using the refs REST routes already use. A test covers that it reaches all of one member's sockets and nobody else's.No database or auth changes.
🤖 Generated with Claude Code