Repository navigation
Take banner and avatar videos when the worker transcodes them (GRYT-1664) - #273
Merged
Merged
Conversation
…664) With video-v1 on the worker's /health, an MP4, WebM or QuickTime banner or avatar goes straight to quarantine, held to the upload limit rather than the avatar one, and the worker writes it out as AV1 MP4. Without it the answer is 415 video_unsupported, which is what a standalone or desktop-hosted server says until it has a sandbox of its own. Co-Authored-By: Claude Opus 5.5 <[email protected]>
avatarVideo and bannerVideo, from the file's type, so a client knows to play it and uses the still thumbnail where it can't. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server half of video banners and avatars. It follows #272, and does nothing until the image worker reports
video-v1(the next worker PR, after image-worker#40).workerCapabilities.tsalso readsvideo-v1. It only counts alongsidequarantine-v1.POST /api/uploads/bannerand/avataracceptvideo/mp4,video/webmandvideo/quicktimewhen the worker transcodes. Such a file goes straight to quarantine and is held to the server's upload limit, which you asked for, not the avatar one. The server never opens it. The worker writes it out as AV1 MP4: no sound, at most 10 seconds, 960x492 or 256x256.Without
video-v1the answer is415 video_unsupported("This server can't take a video here. Use a picture instead."). That's what a standalone or desktop-hosted server says until it has its own sandbox.The multer limit for these two routes is the larger of the avatar and upload limits, but only while video is possible. A picture is still checked against the avatar limit.
The member list carries
avatarVideoandbannerVideo, taken from the file type, so a client knows to play the file and can use the still thumbnail (the poster) where it can't. Both go throughbuildMemberListand the change detector next to it.Not here yet: the clients playing a video banner or avatar. That's the next client PR.
Tests: all pass, plus one new case for refused without
video-v1, taken and quarantined with it.🤖 Generated with Claude Code