Repository navigation
Store banners in the card's own shape, 960x492 - #271
Merged
Merged
Conversation
The banner box was 5:2, but the card shows its banner at 320 by 164. A saved banner was cut to 5:2, then the card cropped and scaled it again, so it looked bigger than in the editor that picked it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why a banner looks different on your card after saving: the server cut every banner to
BANNER_BOXat 960x384 (5:2), but the card draws its banner at 320x164 CSS px (about 1.95:1). The stored picture was cut to 5:2, then the card cropped it again withbackground-size: coverand scaled it up. The editor shows the original file cover-fitted to 320x164, so the two never matched.BANNER_BOXis now 960x492 (3x the card) with a 480x246 thumbnail. Both the server and the card centre-crop to the same shape, so the saved banner matches what the editor showed.Banners already stored stay 960x384 until they're uploaded again.
My mistake originally: I set 5:2 when the banner first shipped (GRYT-1610).
🤖 Generated with Claude Code