Repository navigation
Revert the banner and image quarantine for now - #270
Merged
Merged
Conversation
8d7f9bd sent new banners and image uploads to quarantine/ for the image worker to clear. The worker that clears them (image-worker#38) and the client half (client#770) are not merged, so releasing server main as it stands would leave new banners and chat images unserved. It was never released. The upload-cleaning work is being planned again as one change across server, worker and client. This reverts commit 8d7f9bd. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts 8d7f9bd ("quarantine new media through image worker", merged as #268 on 2 October, never released).
That change writes new banners, and image uploads that get an image job, under
quarantine/, and only the image worker moves them out. The worker side is Gryt-chat/image-worker#38, which isn't merged, and the client side is Gryt-chat/client#770, also unmerged. If server main were released as it is, new banners and chat images would stop being served until the worker caught up. Server main couldn't be released at all, and the banner size fix (next PR) needs a release.Upload cleaning isn't dropped. It's being planned again as one change across server, worker and client, with Sivert reading the worker diff, since image-worker is review-required.
What to look at:
src/routes/uploads.tsandsrc/services/storeUploadedFile.tsare back to their 1.10.49 behaviour, which is what production runs today.🤖 Generated with Claude Code