Repository navigation
Send data-only messages to Android apps that open previews themselves - #4
Merged
Merged
Conversation
A notification message is shown by Android without waking the app, so it could never replace the fixed text with the sealed preview. Phones that register with opens: true get data-only messages carrying the preview and the fallback text (GRYT-1698). Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android phones that can open sealed previews now get data-only messages, so the app gets to build the notification itself (GRYT-1698).
Android shows a message that has a
notificationblock on its own while the app is in the background. The app never sees it, so it can't swap "New message" for who wrote and what. A message with onlydatagoes to the app instead.POST /v1/devicestakesopens: true. The relay only honours it for Android, and stores it in a newopenscolumn. An existing push.db gets the column on start-up withALTER TABLE, defaulting to 0.opensdevice that carries a preview is sent data-only:{ c, p, t, b }, wheretandbare the fixed title and text the app falls back to if it can't openp.Look at:
ALTER TABLEon start-up. It's the first schema change since push.db shipped.opens: truehas to actually handle data-only messages. If it doesn't, it shows nothing at all. The app half is the mobile PR that goes with this one.🤖 Generated with Claude Code